Add coverage include and exclude flags#356
Open
Steffeeen wants to merge 1 commit into
Open
Conversation
These new flags allow filtering which classes get instrumented for collecting coverage.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first time writing custom starlark rules. Please let me know if I need to change anything/did anything wrong.
These new flags allow filtering which classes get instrumented when collecting coverage. The include and exclude lists are the same mechanism as used by JaCoCo.
Example for only instrumenting classes in the
com.examplepackage:bazel coverage //... --@rules_java//java/config:coverage_includes=com/example/*I'm not sure if we should add tests for these new flags or if that's even possible. These new flags also need to be documented somewhere, but I wasn't sure where to put documentation for them.
Requires bazelbuild/bazel#29502 to be merged.