Allow empty list as AccountCreateExtension(s).#90
Merged
Conversation
All other graphene objects accept `[ ]` as extensions placeholder, so AccountCreateExtension should comply.
Codecov Report
@@ Coverage Diff @@
## develop #90 +/- ##
========================================
Coverage 67.64% 67.64%
========================================
Files 51 51
Lines 4086 4086
========================================
Hits 2764 2764
Misses 1322 1322
Continue to review full report at Codecov.
|
xeroc
added a commit
that referenced
this pull request
May 1, 2018
Release 0.1.16 Bug Fix release 531bd37 Merge branch 'release/0.1.16' 85b6b81 version bump 3305dd4 revert changes to blockchain.py 8212175 typo 80cca5e Fix blockchain_instance error in Order().__init__() 8957492 Merge pull request #90 from jhtitor/acc_ext 428b2ae Merge pull request #92 from jhtitor/memo_prefix 32dbef7 Merge pull request #93 from jhtitor/ops_ids 5cc81af Merge pull request #97 from jhtitor/signer_flex 70686fb Merge tag '0.1.15' into develop 1a88459 Return newly created SignedTransaction when `sign` is invoked. This is useful for tearing down/rebuilding and passing transactions around. 25fef98 Add functions to lookup op classes by id and vice-versa. aa2fc96 Allow chain_prefix in Memo to be overwritten. b483949 Allow empty list as AccountCreateExtension(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other graphene objects accept
[ ]as extensions placeholder, so AccountCreateExtension should comply.