Skip to content

Ensure extension update notices only notify once within 24 hours, provide ability to disable all extension update notices #9934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyfeller merged 22 commits into from
Jan 13, 2025
Merged

Ensure extension update notices only notify once within 24 hours, provide ability to disable all extension update notices #9934

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0d3f7ca
Bring extension update check in line with gh check
andyfeller Nov 17, 2024
7b91b17
Refactor extension command testing
andyfeller Nov 18, 2024
6bd01d5
Initial extension update check testing
Dec 1, 2024
97630fe
Enhance extension manager and tests
Dec 9, 2024
a55f50b
Remove Extension.FullName() from interface
Dec 9, 2024
a79e086
Test whether extension update should be checked
andyfeller Dec 9, 2024
10f62b1
Expand update tests for local extensions
andyfeller Dec 9, 2024
a6b8bec
Remove unnecessary Extension.FullName()
andyfeller Dec 9, 2024
52b845b
Refactor local installation manager test by OS
andyfeller Dec 11, 2024
56841d9
Add build constraint for non-Windows systems
andyfeller Dec 12, 2024
c8501d8
Add build constraint for non-Windows systems
andyfeller Dec 12, 2024
c12e369
Implement partial feedback before trunk update
andyfeller Dec 14, 2024
5ad6ccf
Merge branch 'trunk' into andyfeller/cli-cli-8183-timeout-pt2
andyfeller Dec 14, 2024
bfc63a1
Implement remaining PR feedback
andyfeller Dec 14, 2024
edc0351
Fix failig local extension tests
andyfeller Dec 14, 2024
6bbd703
Comment exported functions
andyfeller Jan 9, 2025
889c4c7
Collapse dryrun checks in ext bin upgrade
williammartin Jan 10, 2025
1c32c98
Capture greater detail on updaterEnabled
andyfeller Jan 10, 2025
2006223
Separate logic for checking updates
andyfeller Jan 10, 2025
97eb8a1
Simplifying cleanExtensionUpdateDir logic
andyfeller Jan 10, 2025
0a1c9be
Expand docs on cleaning extension update dir
andyfeller Jan 10, 2025
3ada5af
Enhance help docs on ext upgrade notices
andyfeller Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary Extension.FullName()
  • Loading branch information
@andyfeller
andyfeller committed Dec 9, 2024
commit a6b8bec70d6b23997def1e0de7014a5653317b65
6 changes: 1 addition & 5 deletions pkg/cmd/extension/extension.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ type Extension struct {
}

func (e *Extension) Name() string {
return strings.TrimPrefix(e.FullName(), "gh-")
}

func (e *Extension) FullName() string {
return filepath.Base(e.path)
return strings.TrimPrefix(filepath.Base(e.path), "gh-")
}

func (e *Extension) Path() string {
Expand Down