Skip to content

CACHE-13371: more cache knobs under request.cf object#6300

Open
yj7o5 wants to merge 1 commit intocloudflare:mainfrom
yj7o5:yawar/CACHE-13371_add-cf-cache-control-field
Open

CACHE-13371: more cache knobs under request.cf object#6300
yj7o5 wants to merge 1 commit intocloudflare:mainfrom
yj7o5:yawar/CACHE-13371_add-cf-cache-control-field

Conversation

@yj7o5
Copy link
Contributor

@yj7o5 yj7o5 commented Mar 11, 2026 •
edited
Loading

This PR adds new cache fields under the request cf object to allow more fine grained control to workers fetch API for caching assets.

@yj7o5 yj7o5 force-pushed the yawar/CACHE-13371_add-cf-cache-control-field branch from cea6afc to 7d0e0f9 Compare March 11, 2026 18:06
@yj7o5 yj7o5 marked this pull request as ready for review March 11, 2026 18:07
@yj7o5 yj7o5 requested review from a team as code owners March 11, 2026 18:07
danlapid
danlapid reviewed Mar 11, 2026
View reviewed changes
Copy link
Collaborator

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add new code behind an featureFlags.getWorkerdExperimental() check until we validated that it works as we want in prod, then we can delete the gate.

@yj7o5 yj7o5 force-pushed the yawar/CACHE-13371_add-cf-cache-control-field branch 2 times, most recently from 2bfbff4 to ac4c657 Compare March 11, 2026 20:44
tewaro
tewaro reviewed Mar 12, 2026
View reviewed changes
@yj7o5 yj7o5 force-pushed the yawar/CACHE-13371_add-cf-cache-control-field branch 2 times, most recently from ca0cc98 to 56c519b Compare March 12, 2026 22:23
danlapid
danlapid reviewed Mar 12, 2026
View reviewed changes
@danlapid danlapid requested a review from harrishancock March 12, 2026 22:49
@yj7o5 yj7o5 force-pushed the yawar/CACHE-13371_add-cf-cache-control-field branch from 56c519b to 3096570 Compare March 12, 2026 22:58
harrishancock
harrishancock approved these changes Mar 13, 2026
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 70 untouched benchmarks
⏩ 129 skipped benchmarks1

Comparing yj7o5:yawar/CACHE-13371_add-cf-cache-control-field (d7c8eb8) with main (980b36d)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

jasnell
jasnell reviewed Mar 17, 2026
View reviewed changes
@yj7o5 yj7o5 force-pushed the yawar/CACHE-13371_add-cf-cache-control-field branch from 3096570 to 2778d06 Compare March 17, 2026 18:08
jasnell
jasnell reviewed Mar 17, 2026
View reviewed changes
jasnell
jasnell reviewed Mar 17, 2026
View reviewed changes
jasnell
jasnell reviewed Mar 17, 2026
View reviewed changes
@yj7o5 yj7o5 force-pushed the yawar/CACHE-13371_add-cf-cache-control-field branch from d7c8eb8 to afa4fc6 Compare March 17, 2026 20:23
@yj7o5 yj7o5 force-pushed the yawar/CACHE-13371_add-cf-cache-control-field branch from afa4fc6 to c682942 Compare March 17, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments

@danlapid danlapid danlapid left review comments

@tewaro tewaro tewaro left review comments

@harrishancock harrishancock harrishancock approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yj7o5 @jasnell @harrishancock @danlapid @tewaro