Have node-internal Buffer use JsUint8Array instead of BufferSource#6326
Merged
Have node-internal Buffer use JsUint8Array instead of BufferSource#6326
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
551abeb to
5a67f82
Compare
02ce8ea to
3f2ac4d
Compare
Collaborator
Author
|
/bigbonk update your review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
3f2ac4d to
73265fb
Compare
anonrig
approved these changes
Mar 15, 2026
Member
|
/bigbonk roast this pr |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Use of `BufferSource` has too much overhead for the way that node-internal `Buffer` is used.
73265fb to
581dbcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of
BufferSourcehas too much overhead for the way that node-internalBufferis used.A precursor to converting it all to rust.