Add .rollback() api for workflow step promises#6330
Open
vaishnav-mk wants to merge 2 commits intocloudflare:mainfrom
Open
Add .rollback() api for workflow step promises#6330vaishnav-mk wants to merge 2 commits intocloudflare:mainfrom
vaishnav-mk wants to merge 2 commits intocloudflare:mainfrom
Conversation
anonrig
reviewed
Mar 17, 2026
| // https://opensource.org/licenses/Apache-2.0 | ||
|
|
||
| import { RpcTarget } from 'cloudflare:workers'; | ||
| import * as assert from 'node:assert'; |
Member
There was a problem hiding this comment.
not needed
Suggested change
| import * as assert from 'node:assert'; | |
| import assert from 'node:assert'; |
| class MockStep extends RpcTarget { | ||
| constructor() { | ||
| super(); | ||
| this.calls = []; |
Member
There was a problem hiding this comment.
this can be moved to outside of the constructor and we can remove the constructor statement
Comment on lines
+71
to
+72
| configOrFn !== null && | ||
| configOrFn !== undefined && |
Member
There was a problem hiding this comment.
This does the same exact thing
Suggested change
| configOrFn !== null && | |
| configOrFn !== undefined && | |
| configOrFn != null && |
| if (!this.#promise) { | ||
| this.#launched = true; | ||
| // #execute is non-null here because #promise is only set in this block. | ||
| this.#promise = this.#execute!(this.#rollbackFn, this.#rollbackConfig); |
Member
There was a problem hiding this comment.
Can we eliminate the non-null ! somehow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds steppromise wrapper with .rollback() api for workflow saga rollbacks. step.do() and step.waitforevent() now return steppromise which lets users register a compensation function before the step rpc fires.