Skip to content

fix(create-cloudflare): skip create-vite Install and start now prompt#12866

Merged
edmundhung merged 1 commit intomainfrom
edmundhung/fix-c3-react-app-setup
Mar 13, 2026
Merged

fix(create-cloudflare): skip create-vite Install and start now prompt#12866
edmundhung merged 1 commit intomainfrom
edmundhung/fix-c3-react-app-setup

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Mar 12, 2026 •
edited
Loading

Fixes #12846.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: This doesn't worth a dedicated test, tested manually using the pre-release
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no feature change

A picture of a cute animal (not mandatory, but encouraged)

Open with Devin

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2026

🦋 Changeset detected

Latest commit: 7347ea0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 12, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

✅ All changesets look good

@ask-bonk
Copy link
Contributor

ask-bonk bot commented Mar 12, 2026

I've reviewed the PR thoroughly. Here's my analysis:

The change:

  • Adds --no-immediate flag to create-vite invocations in both React template variants (pages and workers)
  • This suppresses create-vite 8+'s "Install and start now?" interactive prompt that could cause C3's Cloudflare setup steps to be skipped

Verification:

  1. I confirmed --no-immediate is a valid boolean flag in create-vite 8.x (parsed by mri with boolean: ['immediate']). When --no-immediate is passed, argImmediate becomes false, which skips both the prompt and the install+start behavior.
  2. The fix is applied consistently to both template variants (pages at line 17, workers at line 27).
  3. No other templates in C3 use create-vite, so no other templates are affected.
  4. The changeset is correctly formatted as a patch.
  5. CI checks (build, lint, type check, unit tests) are passing. E2E tests are still pending but the existing React E2E tests should cover this.

The fix is correct, minimal, and well-scoped.

LGTM

github run

@edmundhung edmundhung marked this pull request as ready for review March 12, 2026 17:12
@edmundhung edmundhung requested a review from a team as a code owner March 12, 2026 17:12
@workers-devprod
Copy link
Contributor

workers-devprod commented Mar 12, 2026 •
edited
Loading

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]
devin-ai-integration bot reviewed Mar 12, 2026
View reviewed changes
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

dario-piotrowicz
dario-piotrowicz approved these changes Mar 13, 2026
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 13, 2026
@edmundhung edmundhung merged commit 077c4d5 into main Mar 13, 2026
53 of 64 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-c3-react-app-setup branch March 13, 2026 11:45
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 13, 2026
@workers-devprod workers-devprod mentioned this pull request Mar 13, 2026
Merged
petebacondarwin pushed a commit that referenced this pull request Mar 13, 2026
@edmundhung @petebacondarwin
fix(create-cloudflare): skip create-vite Install and start now prompt (…
7669abd 
…#12866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cloudflare modifications can be skipped when using React template

3 participants

@edmundhung @workers-devprod @dario-piotrowicz