[vite-plugin] Fix dev crashes when Worker entries use standard decorators#12887
Open
dmmulroy wants to merge 1 commit intocloudflare:mainfrom
Open
[vite-plugin] Fix dev crashes when Worker entries use standard decorators#12887dmmulroy wants to merge 1 commit intocloudflare:mainfrom
dmmulroy wants to merge 1 commit intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6aa0294 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Contributor
Author
|
Note for transparency: this investigation and the draft fix were generated with GPT-5.4 on xhigh in OpenCode, while being actively monitored, reviewed, and guided by Dillon Mulroy (@dmmulroy). |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
09d5218 to
6aa0294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12626.
Lower standard decorators before Vite's dev module runner evaluates Worker entry modules.
This forces
esbuild.supported.decorators = falseso decorators are lowered consistently in development, and adds unit and e2e regression coverage for the reported crash.A picture of a cute animal (not mandatory, but encouraged)
🦦