fix(tests): Add missing mock parameter to test method signature#332
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Free review on us!CodeRabbit is offering free reviews until Wed Dec 17 2025 to showcase some of the refinements we've made. Comment |
The test_commit_message_validator_failure method had two @patch decorators but only accepted one mock parameter, causing a TypeError in CI. Added mock_get_commit_info parameter to match the decorators. Co-authored-by: shenxianpeng <3353385+shenxianpeng@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add comprehensive tests for configuration and validation
fix(tests): Add missing mock parameter to test method signature
Dec 15, 2025
shenxianpeng
approved these changes
Dec 15, 2025
shenxianpeng
pushed a commit
that referenced
this pull request
Dec 15, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
test_commit_message_validator_failurehad two@patchdecorators but only accepted one mock parameter, causing aTypeErrorin CI.Changes
mock_get_commit_infoparameter to match the@patch("commit_check.engine.get_commit_info")decoratorWhen using multiple
@patchdecorators, pytest requires a parameter for each mock in bottom-to-top order:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.