Feat: Validate message_length_limit is non-negative#1908
Open
ttw225 wants to merge 11 commits intocommitizen-tools:masterfrom
Open
Feat: Validate message_length_limit is non-negative#1908ttw225 wants to merge 11 commits intocommitizen-tools:masterfrom
message_length_limit is non-negative#1908ttw225 wants to merge 11 commits intocommitizen-tools:masterfrom
Conversation
CLI > config > default (0) for not limit
CLI > config > default (0) for not limit
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1908 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 60 60
Lines 2689 2695 +6
=======================================
+ Hits 2635 2641 +6
Misses 54 54 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added validation for
message_length_limitcoming from either CLI or config: it must be a non-negative integer (>= 0). Negative values raiseInvalidCommandArgumentError.Checklist
Was generative AI tooling used to co-author this PR?
Co-generated-by: [Cursor] following the guidelines
Code Changes
uv run poe alllocally to ensure this change passes linter check and testsDocumentation Changes
uv run poe doclocally to ensure the documentation pages renders correctlyExpected Behavior
--message-length-limit -1ormessage_length_limit = -1in config results in an error (InvalidCommandArgumentError).Steps to Test This Pull Request
cz check -l -1 --message "feat: hello"cz commit -l -1Additional Context