Skip to content

fix: jump page on hold in font family and language selection#1925

Open
zgredex wants to merge 2 commits into
crosspoint-reader:masterfrom
zgredex:fix/font-family-hold-page
Open

fix: jump page on hold in font family and language selection#1925
zgredex wants to merge 2 commits into
crosspoint-reader:masterfrom
zgredex:fix/font-family-hold-page

Conversation

@zgredex
Copy link
Copy Markdown
Contributor

@zgredex zgredex commented May 10, 2026 •
edited
Loading

Summary

  • Holding the navigation button in Settings → Reader → Font family now advances the selection by a full visible page instead of one item at a time.
  • Same fix applied to Settings → Language, which had the same one-item-only behavior.
  • Mirrors the pattern already used in font download (ceb3fed) and chapter selection screens.

Test plan

  • Settings → Reader → Font family: tap moves by one item; hold jumps a page (wraps at ends)
  • Settings → Language: tap moves by one item; hold jumps a page (wraps at ends)

@zgredex
fix: jump page on hold in font family selection
2fa708b 
Hold the navigation button to advance by a full visible page in the
Reader font family list, matching the pattern used in font download
and chapter selection screens.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 10, 2026 •
edited
Loading

Review Change Stack

📝 Walkthrough

Walkthrough

Settings activities compute list size and items-per-page, then use listSize for release-based single-step navigation and pageItems with ButtonNavigator helpers for continuous (page) navigation in FontSelectionActivity and LanguageSelectActivity.

Changes

Settings Pagination Navigation

Layer / File(s) Summary
Font list: pagination-aware navigation
src/activities/settings/FontSelectionActivity.cpp		 loop() computes listSize and pageItems once; release Next/Previous use listSize, continuous Next/Previous use ButtonNavigator::nextPageIndex/previousPageIndex with pageItems.
Language list: pageItems computation
src/activities/settings/LanguageSelectActivity.cpp		 Adds pageItems computed from UITheme::getNumberOfItemsPerPage(...) to support page-based navigation.
Language list: continuous page navigation handlers
src/activities/settings/LanguageSelectActivity.cpp		 Adds onNextContinuous and onPreviousContinuous handlers that jump by page using ButtonNavigator::{nextPageIndex,previousPageIndex} and call requestUpdate().

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • mcrosson
  • pablohc
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately describes the main changes: implementing page-jump behavior on hold for both font family and language selection screens, which are the primary objectives of this PR.
Description check ✅ Passed The pull request description accurately describes the changes: adding page-based navigation to font family and language selection screens by holding navigation buttons, matching an established pattern in other parts of the application.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zgredex zgredex force-pushed the fix/font-family-hold-page branch from c23ac7a to 2fa708b Compare May 10, 2026 18:31
@zgredex zgredex changed the title feat: jump page on hold in font family selection fix: jump page on hold in font family selection May 10, 2026
@zgredex
Copy link
Copy Markdown
Contributor Author

zgredex commented May 10, 2026 •
edited
Loading

Same kind of nitpick as my last fix. With all fonts downloaded the list can exceed one page. This brings font selector and language selector behavior in line with the rest of the system

@zgredex
fix: jump page on hold in language selection
daf431f 
Same hold-to-page behavior as the font family list.
@zgredex zgredex changed the title fix: jump page on hold in font family selection fix: jump page on hold in font family and language selection May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@znelson znelson Awaiting requested review from znelson

@mcrosson mcrosson Awaiting requested review from mcrosson

@pablohc pablohc Awaiting requested review from pablohc

@Uri-Tauber Uri-Tauber Awaiting requested review from Uri-Tauber

At least 2 approving reviews are required to merge this pull request.

Assignees

@znelson znelson

@mcrosson mcrosson

@pablohc pablohc

@Uri-Tauber Uri-Tauber

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zgredex @znelson @mcrosson @pablohc @Uri-Tauber