docs(containers): move GPU access to dedicated page#24433
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR successfully moves GPU access documentation to a dedicated page with several improvements:
✅ Well-structured content: Clear progression from prerequisites → installation → usage examples
✅ Updated examples: Replaces outdated nvidia-smi output (GRID K520, driver 384) with current output (NVIDIA L4, driver 535, CUDA 12.2)
✅ Improved accuracy: Correctly shows how to retrieve GPU UUIDs with nvidia-smi -L instead of claiming they come from the Bus-Id column
✅ Better context: Each code example now has proper explanatory text before it
✅ Style compliance: No hedge words, proper code formatting, follows STYLE.md guidelines
✅ Front matter: Complete with appropriate title, description, and keywords
The resource_constraints.md page now focuses solely on memory and CPU constraints with a clean stub linking to the new GPU page.
No issues found.
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
7b8e160 to
0913862
Compare
dvdksn
left a comment
There was a problem hiding this comment.
LGTM thanks for this change @doringeman 🚀
Description
Moves the GPU access content out of
resource_constraints.mdinto a new dedicated pagegpu.md. The resource constraints page now contains only memory and CPU content, with a stub linking to the new page.Also improves the GPU page:
nvidia-smioutput (GRID K520, driver 384) with current output (NVIDIA L4, driver 535, CUDA 12.2)nvidia-smi -Lstep to show how to retrieve UUIDsReviews