[iOS, macOS] Refresh card suffix on incoming Sync card number update#4805
Open
amddg44 wants to merge 3 commits into
Open
[iOS, macOS] Refresh card suffix on incoming Sync card number update#4805amddg44 wants to merge 3 commits into
amddg44 wants to merge 3 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1201462886803403/task/1214548114411709?focus=true
Tech Design URL:
CC:
Description
This PR fixes credit-card sync suffix consistency by running a one-time update of any stale stored suffixes and by always recalculating suffix when card numbers are updated.
Testing Steps
Test card numbers can be found here
1111so it exists on both platforms.1111)Impact and Risks
Low: Minor visual changes, small bug fixes, improvement to existing features
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Medium Risk
Touches credit-card sync storage and performs a one-time backfill that decrypts card data and updates the vault database; issues here could impact card display data or sync correctness.
Overview
Ensures
cardSuffixstays in sync withcardNumberfor credit cards coming from Sync by recalculating the suffix whenever a synced card number is stored/updated.Adds a one-time post-sync backfill in
CreditCardsProviderthat decrypts existing stored card numbers, updates any stalecardSuffixvalues directly in the database, and gates the migration via a persisted key-value flag (plumbed through iOS/macOS adapters and tests).Reviewed by Cursor Bugbot for commit 09bb80f. Bugbot is set up for automated code reviews on this repo. Configure here.