Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1214525802264426
Tech Design URL: https://app.asana.com/1/137249556945/project/481882893211075/task/1214488238400075
CC: N/A

Description

• Add displayConditions wrapper object to RMF message JSON config, nesting dismissAfterDaysShown and a new trigger field
• Add MessageTrigger enum and DisplayConditions struct to the domain model; messages with unknown triggers are silently discarded for forward compatibility
• Extend fetchScheduledRemoteMessage with an optional trigger parameter for filtering messages by their trigger context
• Thread idle-return context through iOS: HomePageConfiguration.refresh(openedAfterIdle:) passes trigger: .afterIdle when the user returns from idle, and NewTabPageMessagesModel forwards this via an isOpenedAfterIdle closure
• After-idle messages now appear in both the main NTP and the focussed NTP (suggestion tray), by passing hasEscapeHatch to the focussed NTP in SuggestionTrayViewController
• Auto-dismiss via dismissAfterDaysShown continues to work as before, now nested under displayConditions

Testing Steps

Test 1 -- Regular message (no trigger, no auto-dismiss):

1. Apply config from https://pastebin.com/raw/zTS5cAE1 via Debug > Remote Messages > Set source URL, then reset messages and reload
2. Verify the "Regular Message" appears on the NTP on normal launch
3. Dismiss it and verify it stays dismissed

Test 2 -- After-idle trigger only:

1. Apply config from https://pastebin.com/raw/MmpU87dY via Debug > Remote Messages > Set source URL, then reset messages and reload
2. Kill and relaunch the app normally -- the message should not appear
3. Trigger idle return (background app, wait for threshold, return) -- the "Welcome Back!" message should appear on the main NTP
4. Tap the address bar -- the message should also appear in the focussed NTP
5. Dismiss the escape hatch, open a new tab -- the message should not appear (no idle context)

Test 3 -- Normal app usage after idle return:

1. After idle return, verify the message appears
2. Navigate to a URL, then open a new tab -- the message should not appear (no idle context)

Test 4 -- After-idle + auto-dismiss combo:

1. Apply config from https://pastebin.com/raw/azMhR7mc
2. Trigger idle return -- "Time-limited idle message" should appear
3. Move the device date forward by 2+ days, trigger idle return again -- the message should no longer appear (auto-dismissed)

Test 5 -- Unknown trigger (forward compatibility):

1. Apply config from https://pastebin.com/raw/RhCG3Kaj
2. The message should never appear -- the unknown trigger causes it to be discarded during mapping

Impact and Risks

Impact Level: Low

What could go wrong?

• If the escape hatch state is not set before the focussed NTP's onAppear fires, the after-idle message may not show in focussed mode. Mitigated by the fact that setEscapeHatch is called before the view is installed in the hierarchy
• Messages with unknown triggers are silently dropped, which is the intended forward-compatibility behavior but could cause confusion if a trigger name is misspelled in the server config

Quality Considerations

• displayConditions is fully backward compatible; messages without it behave identically to before
• Unknown triggers are discarded at the mapping layer to avoid showing messages at wrong times
• Unit tests cover: trigger mapping, unknown trigger discard, backward compat, store trigger filtering, auto-dismiss with trigger combo, iOS wiring (HomePageConfiguration and NewTabPageMessagesModel)

Notes to Reviewer

• The displayConditions wrapper replaces the top-level dismissAfterDaysShown field in the JSON schema. The domain model groups both fields under DisplayConditions
• The focussed NTP fix was a one-line addition in SuggestionTrayViewController to forward the escape hatch state
• This is a re-open of Add auto-dismiss capability to Remote Messaging Framework #4743 which was closed when release/ios/7.219.0 was deleted

Made with Cursor