This repository was archived by the owner on Feb 24, 2025. It is now read-only.
correctly update the ui after rotation#3881
Merged
Merged
Conversation
Bunn
approved these changes
Jan 27, 2025
Contributor
Bunn
left a comment
There was a problem hiding this comment.
Approved, but see comment on asana
Bunn
added a commit
that referenced
this pull request
Feb 11, 2025
Task/Issue URL: https://app.asana.com/0/414709148257752/1209376796676971/f **Description**: Fixes crash introduced on #3881
dus7
added a commit
that referenced
this pull request
Feb 11, 2025
Task/Issue URL: https://app.asana.com/0/414709148257752/1209376796676971/f Tech Design URL: CC: **Description**: Fixes crash introduced on #3881 <!-- If at any point it isn't actively being worked on/ready for review/otherwise moving forward strongly consider closing it (or not opening it in the first place). If you decide not to close it, use Draft PR while work is still in progress or use `DO NOT MERGE` label to clarify the PRs state and comment with more information. --> Recreated from [already accepted PR](#3956). **Steps to test this PR**: 1.Test rotation to / from landscape with and without the keyboard. Confirm that the UI updates as expected and that the keyboard remains visible if it was visible before rotation. 2.Validate iPad behaviour remains the same. **Definition of Done (Internal Only)**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? Co-authored-by: Fernando Bunn <bunn@idevzilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/392891325557410/1209237053406464/f
Tech Design URL:
CC:
Description:
Correctly update the UI after rotation, especially showing the keyboard if it was previously shown.
Steps to test this PR:
Definition of Done (Internal Only):