Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Update scheme names#3913

Merged
samsymons merged 4 commits into
mainfrom
sam/rename-schemes
Feb 3, 2025
Merged

Update scheme names#3913
samsymons merged 4 commits into
mainfrom
sam/rename-schemes

Conversation

@samsymons
Copy link
Copy Markdown
Contributor

@samsymons samsymons commented Feb 2, 2025

Task/Issue URL: https://app.asana.com/0/1193060753475688/1209299354320297
Tech Design URL:
CC:

Description:

This PR renames iOS scheme names.

Steps to test this PR:

  1. Check that CI is green
  2. Check that localized string export/import works
  3. Check that there are no leftover references to scheme names in workflows, Fastlane, etc.
  4. Confirm that this ad-hoc workflow run succeeded
  5. Confirm that this alpha workflow run succeeded
  6. Confirm that this E2E test run succeeded to build and start testing (no promises about tests succeeding)

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons marked this pull request as ready for review February 2, 2025 17:22
@samsymons samsymons requested a review from ayoy February 2, 2025 17:22
@samsymons
Copy link
Copy Markdown
Contributor Author

PR subtask creation failed, the changes in this PR should be unrelated to that workflow though.

Copy link
Copy Markdown
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @samsymons! I've updated one reference to an old scheme in setup_ui_tests.sh, which I'm not sure if is in use anyway :)

@samsymons samsymons merged commit 68d79a7 into main Feb 3, 2025
@samsymons samsymons deleted the sam/rename-schemes branch February 3, 2025 23:02
ayoy pushed a commit that referenced this pull request Feb 7, 2025
Task/Issue URL: https://app.asana.com/0/1193060753475688/1209299354320297
Tech Design URL:
CC:

Description:

This PR renames iOS scheme names.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants