This repository was archived by the owner on Feb 24, 2025. It is now read-only.
DuckPlayer: 31. PoC: Open Player Links in Youtube#3919
Merged
Conversation
Bunn
approved these changes
Feb 3, 2025
Contributor
Bunn
left a comment
There was a problem hiding this comment.
LGTM.
I’m assuming the iPad is not a concern on this stage of the PoC though. Something to keep in mind on the isLandscape check
Contributor
Author
|
@Bunn Correct. Ipad is out of the picture |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1209253933548205
Tech Design URL:
CC:
Description:
Open Player links in a clean YouTube view.
Steps to test this PR:
Definition of Done (Internal Only):