Skip to content

Update tests.yml#60

Open
artmel130590 wants to merge 1 commit into
duckduckgo:gd-tds-202512from
artmel130590:patch-1
Open

Update tests.yml#60
artmel130590 wants to merge 1 commit into
duckduckgo:gd-tds-202512from
artmel130590:patch-1

Conversation

@artmel130590
Copy link
Copy Markdown

@artmel130590 artmel130590 commented Dec 5, 2025

Guys good day!
Who knows what was that on my phone?
Im using Samsung galaxy


Note

Switch tests workflow to run on close and clear the job runner and test command.

  • CI:
    • /.github/workflows/tests.yml:
      • Change trigger from on: [push, pull_request] to on: [ close ].
      • Remove runs-on value for unit job.
      • Clear Run tests step by removing npm run test command.

Written by Cursor Bugbot for commit 709213e. This will update automatically on new commits. Configure here.

name: Test blocklists before release

on: [push, pull_request]
on: [ close ]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Workflow trigger event is invalid and breaks CI

This appears to be an accidental edit (the PR description mentions phone/Samsung device). The workflow is now broken in multiple ways: the on: [ close ] trigger uses an invalid event name (GitHub Actions has no close event), runs-on: is empty (missing required runner like ubuntu-latest), and run: for tests is empty (missing npm run test). These changes completely disable the test workflow and will cause parsing errors.


Please tell me if this was useful or not with a 👍 or 👎.

Additional Locations (2)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant