Added the command generator and somewhat integrated the first result.#290
Closed
Miro-Andrin wants to merge 9 commits intofeather-rs:mainfrom
Closed
Added the command generator and somewhat integrated the first result.#290Miro-Andrin wants to merge 9 commits intofeather-rs:mainfrom
Miro-Andrin wants to merge 9 commits intofeather-rs:mainfrom
Conversation
Contributor
Author
|
The refactoring of #307 Into Minecraft 16.2 has moved were code generation happens. I am going to change this pull request, so that it better matches the new refactoring, once the changes are merged. |
Member
Sounds good, thanks for your work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have included the code i used to parse mojang's commands.json file. I put it at the top of the folder hierarchy in the folder command_generator. Not sure if that is where you want it, but that is were i put it.
Note: I have also "integrated" the first result when running the utility. The project compiles, but all the existing command handling code has been commented out and left where it was. That means no commands are currently working.
I have run into two issues when integrating the generated code. First of all i have discovered some bugs in lieutenant that prevents me from integrating all the commands. That is why some functions in impls.rs and lib.rs are commented out. I am going to open a Issue.
Another issue is the size of impls.rs, without adding any functionality it has reached 10_000 lines of code. In my editor, the highlighting/hints were unbearably slow. Maybe it should be split up, to make it more pleasant to work with.