Skip to content

Various physics improvements#98

Merged
caelunshun merged 8 commits intodevelopfrom
fix/physics
Aug 31, 2019
Merged

Various physics improvements#98
caelunshun merged 8 commits intodevelopfrom
fix/physics

Conversation

@caelunshun
Copy link
Member

@caelunshun caelunshun commented Aug 31, 2019

Improve physics in the following ways:

@caelunshun caelunshun added this to the 0.4 milestone Aug 31, 2019
@codecov
Copy link

codecov bot commented Aug 31, 2019

Codecov Report

Merging #98 into develop will decrease coverage by 1.51%.
The diff coverage is 6%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
- Coverage    54.87%   53.36%   -1.52%     
===========================================
  Files           56       55       -1     
  Lines         7050     7038      -12     
===========================================
- Hits          3869     3756     -113     
- Misses        3181     3282     +101
Impacted Files Coverage Δ
core/src/lib.rs 0% <ø> (-9.81%) ⬇️
server/src/physics/entity.rs 8.21% <0%> (-2.31%) ⬇️
server/src/player/digging.rs 96.3% <100%> (+0.01%) ⬆️
server/src/entity/item.rs 94.11% <100%> (ø) ⬆️
core/src/world/mod.rs 38.04% <11.76%> (-3.01%) ⬇️
server/src/physics/math.rs 64.68% <4.95%> (-24.03%) ⬇️
server/src/physics/component.rs 87.8% <0%> (-7.32%) ⬇️
server/src/joinhandler.rs 30.23% <0%> (-1.23%) ⬇️
server/src/config.rs 87.5% <0%> (-0.38%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb52dc...064dd9b. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 31, 2019 •
edited
Loading

Codecov Report

Merging #98 into develop will increase coverage by 0.99%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #98      +/-   ##
===========================================
+ Coverage    54.87%   55.87%   +0.99%     
===========================================
  Files           56       56              
  Lines         7050     7313     +263     
===========================================
+ Hits          3869     4086     +217     
- Misses        3181     3227      +46
Impacted Files Coverage Δ
server/src/util/macros.rs 100% <ø> (ø) ⬆️
core/src/lib.rs 9.8% <ø> (ø) ⬆️
server/src/entity/item.rs 94.11% <100%> (ø) ⬆️
server/src/physics/component.rs 95.12% <100%> (ø) ⬆️
core/src/world/mod.rs 38.04% <11.76%> (-3.01%) ⬇️
server/src/physics/math.rs 83.2% <68.59%> (-5.51%) ⬇️
server/src/physics/entity.rs 73.91% <79.59%> (+63.38%) ⬆️
server/src/joinhandler.rs 28.34% <0%> (-3.12%) ⬇️
server/src/player/init.rs 98.82% <0%> (-1.18%) ⬇️
core/src/save/player_data.rs 89.04% <0%> (+8.68%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f038c...a155a0a. Read the comment docs.

@caelunshun caelunshun changed the title Various physics improvements [WIP] Various physics improvements Aug 31, 2019
@caelunshun caelunshun marked this pull request as ready for review August 31, 2019 04:32
@caelunshun caelunshun merged commit 6ddf4bf into develop Aug 31, 2019
@caelunshun caelunshun deleted the fix/physics branch August 31, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4

Development

Successfully merging this pull request may close these issues.

When landing on the ground, item entities "jitter" for a while before settling Entities occasionally travel partially into a block

1 participant

@caelunshun