Create/Update tenant with ReCAPTCHA Config#1586
Merged
Merged
Conversation
- Updated reCaptcha config type align with backend API. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants.
renkelvin
reviewed
Mar 4, 2022
renkelvin
left a comment
There was a problem hiding this comment.
Looks good to me. Please add Lahiru for approval.
renkelvin
approved these changes
Mar 4, 2022
lahirumaramba
requested changes
Mar 5, 2022
Member
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you, Liubin!
I added some comments and questions. Didn't get a chance to dive into unit tests. I will take another look later. Thanks!
Major updates - Removed ManagedRuleAuth class and move the validation to recaptchaAuthConfig object.
Contributor
Author
Thank you @lahirumaramba for the review. Addressed majority comments. Resolved the trivial changes and left comments on the ones needed. |
lahirumaramba
approved these changes
Mar 7, 2022
Member
lahirumaramba
left a comment
There was a problem hiding this comment.
Thank you! Just a few nits but otherwise LGTM!
| '"RecaptchaConfig.emailPasswordEnforcementState" must be either "OFF", "AUDIT" or "ENFORCE".', | ||
| ); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
The SDK shouldn't allow empty strings in the request to the BE service so this error technically should not occur (from the backend). I felt like the check is redundant because you check for a restricted set of strings here regardless. Not a big issue so I will leave it up to you to decide the best path here.
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Mar 2, 2023
* Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Mar 30, 2023
* Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 11, 2023
* Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 12, 2023
* Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations.
Xiaoshouzi-gh
added a commit
that referenced
this pull request
Apr 12, 2023
reCAPTCHA support * Defined reCAPTCHA config. (#1574) - Added reCAPTCHA protection states. - Added reCAPTCHA action rule. - Added reCAPTCHA key config. * Create/Update tenant with ReCAPTCHA Config (#1586) * Support reCaptcha config /create update on tenants. - Support create and update tenants with reCaptcha config. - Added reCaptcha unit tests on tenants operations. * Project config - Recaptcha config (#1595) * Recaptcha config changes in project config. - Implemented getProjectConfig. - Implemented updateProjectConfig. - Updated error code. - Add Term of Service consents. * Recapcha integ test (#1599) * Added integ test for Project Config and Tenants update on reCAPTCHA config * Account defender support for reCAPTCHA (#1616) * Support use_account_defender add-on feature for reCAPTCHA config. * Added integration test for account defender feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support reCaptcha config /create update on tenants.
- Updated reCaptcha config type align with backend API.
- Support create and update tenants with reCaptcha config.
- Added reCaptcha unit tests on tenants.
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.