@google-cloud/firestore optional dependency ^6.6.0 -> ^6.8.0#2351
Closed
joehan wants to merge 3 commits into
Closed
@google-cloud/firestore optional dependency ^6.6.0 -> ^6.8.0#2351joehan wants to merge 3 commits into
joehan wants to merge 3 commits into
Conversation
|
Actually would be great if this would be bumped to the latest 7.x versions but those contain a breaking change. I guess that would require a new major release. Not sure. |
Member
|
Fixed in #2385 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumping up @google-cloud/firestore dependency to the latest 6.x version.
Per https://github.com/googleapis/nodejs-firestore/releases/tag/v6.7.0, multidb support was only added in 6.7.0. https://firebase.google.com/docs/reference/admin/node/firebase-admin.firestore.md#getfirestore says that we support this, so we should require at least 6.7.0. Currently, this silently write/reads from the default DB if you try to use a different DB and have firestore@6.6.0 in your node modules.