Workaround Carthage Protobuf parallel install issue#5345
Merged
Conversation
ryanwilson
approved these changes
Apr 14, 2020
Member
ryanwilson
left a comment
There was a problem hiding this comment.
Code LGTM. Are there any concerns about folks updating and things breaking for them? Although realistically they may just leave the existing framework in there and override the old ones... that could be a separate issue seen if Protobuf changes.
| } | ||
|
|
||
| /// Factor Protobuf into a separate Carthage distribution to avoid Carthage install issues | ||
| /// trying to install the same framework from multiple bundles(#5276). |
Member
Author
|
Breakage is definitely a concern but the current breakage described in #5276 seems worse. Mitigating the risk with documentation. And at least Protobuf is reasonably stable so is unlikely to break if people continue to use the old one and don't update to the new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5276. Carthage can fail to install if two binary installs include the same framework. This PR factors Protobuf.framework out of the several bundles it was included in into a single Carthage bundle.
The instructions are updated to describe when the new
FirebaseProtobufBinary.jsonmust now be included in the Cartfile.