[App Distribution] Fix crash caused by response being nil#7067
Merged
Conversation
pranavrajgopal
approved these changes
Dec 1, 2020
When an error occurs, the response data will be nil. This causes a crash because we are trying to parse the response as JSON. Instead, return a generic error message if the response data is nil.
cc7ac56 to
0ab8518
Compare
tagboola
approved these changes
Dec 1, 2020
paulb777
reviewed
Dec 1, 2020
b0e18d2 to
1df1453
Compare
paulb777
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an error occurs, the response data will be nil. This causes a crash because we are trying to parse the response as JSON. Instead, return a generic error message if the response is nil.
Fixes #6996