Skip to content

Rebuild flutter tool skill#184975

Merged
auto-submit[bot] merged 7 commits into
flutter:masterfrom
vashworth:rebuild-flutter-tool-skill
Apr 14, 2026
Merged

Rebuild flutter tool skill#184975
auto-submit[bot] merged 7 commits into
flutter:masterfrom
vashworth:rebuild-flutter-tool-skill

Conversation

@vashworth
Copy link
Copy Markdown
Contributor

@vashworth vashworth commented Apr 13, 2026

Adds a skill that instructs an agent to rebuild the Flutter tool/CLI.

This skill allows you to ask your agent to rebuild for you without you needing to remember the location.

Example 1
# Chat Conversation

Note: _This is purely the output of the chat conversation and does not contain any raw data, codebase snippets, etc. used to generate the output._

### User Input

rebuild the flutter tool

*User accepted the command `flutter help`*

*Viewed [SKILL.md](file:///Users/vashworth/Development/flutter/.agents/skills/rebuilding-flutter-tool/SKILL.md) *

*User accepted the command `./rebuild.sh`*

### Planner Response

`./rebuild.sh` is running in the background. I will wait for it to complete.

### Planner Response

**Flutter tool rebuilt successfully!**
Example 2
# Chat Conversation

Note: _This is purely the output of the chat conversation and does not contain any raw data, codebase snippets, etc. used to generate the output._

### User Input

rebuild cli

*User accepted the command `flutter help`*

*Viewed [SKILL.md](file:///Users/vashworth/Development/flutter/.agents/skills/rebuilding-flutter-tool/SKILL.md) *

*User accepted the command `./rebuild.sh`*

### Planner Response

I have started rebuilding the Flutter tool by executing the `rebuild.sh` script. I will wait for the background task to complete and verify the output.

### Planner Response

**Flutter tool rebuilt successfully!**

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@vashworth vashworth marked this pull request as ready for review April 13, 2026 16:49
@vashworth vashworth requested a review from reidbaker as a code owner April 13, 2026 16:49
@vashworth vashworth added the CICD Run CI/CD label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a workflow and script for rebuilding the Flutter tool. Feedback includes correcting a directory path in the documentation, adding error handling to the shell script, and using a relative path to the local Flutter binary to ensure the correct version is executed.

Comment thread .agents/skills/rebuilding-flutter-tool/SKILL.md Outdated
Comment thread .agents/skills/rebuilding-flutter-tool/scripts/rebuild.sh
Comment thread .agents/skills/rebuilding-flutter-tool/scripts/rebuild.sh Outdated
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 13, 2026
@vashworth vashworth added the CICD Run CI/CD label Apr 13, 2026
Copy link
Copy Markdown
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add this file and your name in CODEOWNERS?

Comment thread .agents/skills/rebuilding-flutter-tool/SKILL.md
Comment thread .agents/skills/rebuilding-flutter-tool/scripts/rebuild.sh
@reidbaker reidbaker requested a review from bkonyi April 13, 2026 17:23
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 13, 2026
@vashworth vashworth added the CICD Run CI/CD label Apr 13, 2026
@reidbaker
Copy link
Copy Markdown
Contributor

FWIW I think you want the script executable.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting up to speed on skills, but I wonder if it's worth pointing out that this skill should also be executed when changes to packages/flutter_tools/lib/* have been made and we want to execute flutter, including from tests. Running tests that execute flutter can give incorrect results if we don't rebuild the snapshot after making changes to the tool, which is extremely confusing if you don't know that the test is using an old snapshot.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion here: #184975 (comment)

I think that'd also be great, but I think out of scope for what I'm trying to achieve with this skill. There are many use cases where you may want to rebuild the tool, but we'd likely need to come up with some kind of mechanism to determine if it's necessary first.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another example would be when running through Xcode it calls flutter assemble, which you can't use flutter-dev for since it's baked into the Xcode build process.

I can file an issue to iterate on this skill in the future

Copy link
Copy Markdown
Contributor

@reidbaker reidbaker Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much more articluate version of what I attempted to ask in #184975 (comment) and the answer was no, for now and for how victoria has envisioned wanting this skill to work. We are operating on absolute authority from the owner for most things.

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026
@auto-submit auto-submit Bot added this pull request to the merge queue Apr 14, 2026
Merged via the queue into flutter:master with commit c1b14e9 Apr 14, 2026
54 of 55 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 14, 2026
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 14, 2026
flutter/flutter@2fa45e0...c1b14e9

2026-04-14 15619084+vashworth@users.noreply.github.com Rebuild flutter tool skill (flutter/flutter#184975)
2026-04-14 engine-flutter-autoroll@skia.org Roll Skia from 0851d988db03 to 4c382df6a25a (1 revision) (flutter/flutter#185025)
2026-04-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 5504504b38c2 to ee5afcef0596 (1 revision) (flutter/flutter#185024)
2026-04-14 dacoharkes@google.com [ci] Split up integration.shard record_use_test.dart (flutter/flutter#185022)
2026-04-14 engine-flutter-autoroll@skia.org Roll Skia from d34c84df4c37 to 0851d988db03 (3 revisions) (flutter/flutter#185012)
2026-04-14 dacoharkes@google.com [record_use] Add recorded uses to link hooks (flutter/flutter#184869)
2026-04-14 engine-flutter-autoroll@skia.org Roll Skia from 0e98a9c635bb to d34c84df4c37 (5 revisions) (flutter/flutter#185009)
2026-04-14 engine-flutter-autoroll@skia.org Roll Dart SDK from ef28089d6533 to 5504504b38c2 (3 revisions) (flutter/flutter#185008)
2026-04-14 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from K_2AkZL3Drs6cGE1q... to rB8LAuZL_DwHMssTU... (flutter/flutter#185007)
2026-04-14 rmacnak@google.com [fuchsia] Replace ambient-replace-as-executable with VmexResource. (flutter/flutter#184967)
2026-04-13 chinmaygarde@google.com [Impeller] Commands that don't specify their own viewports get the viewport of the render pass. (flutter/flutter#177473)
2026-04-13 engine-flutter-autoroll@skia.org Roll Skia from bc1df263ff3f to 0e98a9c635bb (1 revision) (flutter/flutter#184995)
2026-04-13 737941+loic-sharma@users.noreply.github.com Update autosubmit guide with the emergency label (flutter/flutter#184993)
2026-04-13 69043738+aNOOBisTheGod@users.noreply.github.com [flutter_tools] Cache pubspec reads and share PackageGraph/PackageConfig across workspace packages during pub get post-processing (flutter/flutter#184528)
2026-04-13 15619084+vashworth@users.noreply.github.com Fix codesign verification test for SwiftPM Add to App (flutter/flutter#184980)
2026-04-13 87962825+kyungilcho@users.noreply.github.com Preprovision Android NDK for flavored builds and reuse matching unflavored NDKs (flutter/flutter#183555)
2026-04-13 15619084+vashworth@users.noreply.github.com Reland "Disable async mode with LLDB" (flutter/flutter#184970)
2026-04-13 engine-flutter-autoroll@skia.org Roll Skia from 55ddd6bb8be5 to bc1df263ff3f (6 revisions) (flutter/flutter#184968)
2026-04-13 matej.knopp@gmail.com Expose platform specific handles for multi-window API (flutter/flutter#184662)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC boetger@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
master-wayne7 pushed a commit to master-wayne7/flutter that referenced this pull request Apr 15, 2026
Adds a skill that instructs an agent to rebuild the Flutter tool/CLI. 

This skill allows you to ask your agent to rebuild for you without you
needing to remember the location.

<details>
  <summary>Example 1</summary>
  
```
# Chat Conversation

Note: _This is purely the output of the chat conversation and does not contain any raw data, codebase snippets, etc. used to generate the output._

### User Input

rebuild the flutter tool

*User accepted the command `flutter help`*

*Viewed [SKILL.md](file:///Users/vashworth/Development/flutter/.agents/skills/rebuilding-flutter-tool/SKILL.md) *

*User accepted the command `./rebuild.sh`*

### Planner Response

`./rebuild.sh` is running in the background. I will wait for it to complete.

### Planner Response

**Flutter tool rebuilt successfully!**
```

</details>

<details>
  <summary>Example 2</summary>
  
```
# Chat Conversation

Note: _This is purely the output of the chat conversation and does not contain any raw data, codebase snippets, etc. used to generate the output._

### User Input

rebuild cli

*User accepted the command `flutter help`*

*Viewed [SKILL.md](file:///Users/vashworth/Development/flutter/.agents/skills/rebuilding-flutter-tool/SKILL.md) *

*User accepted the command `./rebuild.sh`*

### Planner Response

I have started rebuilding the Flutter tool by executing the `rebuild.sh` script. I will wait for the background task to complete and verify the output.

### Planner Response

**Flutter tool rebuilt successfully!**
```
</details>

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants