[Fonts] Update icons#96115
Merged
Merged
Conversation
|
Gold has detected about 3 new digest(s) on patchset 2. |
|
Gold has detected about 2 new digest(s) on patchset 3. |
rami-a
approved these changes
Jan 4, 2022
godofredoc
pushed a commit
that referenced
this pull request
Feb 19, 2022
* Revert "[Fonts] Update icons (#95007)" (#95966) This reverts commit 99977ce. * [Fonts] Update icons (#96115) * update icons * add regression test * add fix for pie_chart_outline * 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml' * 'Update Engine revision to a83ed0e5e3b9cd2b5e2f07ef31c72f43c55e93b7 for stable release 2.10.2' * remove ref to enabled branch Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com> Co-authored-by: Kevin Chisholm <kevinjchisholm@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reland #95007. It was reverted in #95966 to fix an issue with the font.
Fixes #95886 and adds a golden regression test. This PR also adds a Dart fix for the removed
Icons.pie_chart_outlined.Original description
This PR adds 1028 new icons.
Starting with this update and going forward, existing codepoints will be stable between updates. This has the nice side effect of making diffs readable. There is one exception for this particular update for
wifi_tethering_error_rounded_sharpandwifi_tethering_error_rounded_outlined.Closes #88852
Closes #91553
Closes #95238