Skip to content

Cherrypicks flutter 2.8 candidate.16#96495

Merged
itsjustkevin merged 3 commits into
flutter:flutter-2.8-candidate.16from
itsjustkevin:cherrypicks-flutter-2.8-candidate.16
Jan 12, 2022
Merged

Cherrypicks flutter 2.8 candidate.16#96495
itsjustkevin merged 3 commits into
flutter:flutter-2.8-candidate.16from
itsjustkevin:cherrypicks-flutter-2.8-candidate.16

Conversation

@itsjustkevin
Copy link
Copy Markdown
Contributor

Flutter beta 2.10.0-0.1.pre Flutter

Scheduled Cherrypicks

  • none

@flutter-dashboard
Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard
Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard Bot added the engine flutter/engine related. See also e: labels. label Jan 12, 2022
Copy link
Copy Markdown
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's merging a new version of the engine - 63ca99584a1aef79722b2a7c6414570b54416bab - into flutter/flutter, and into the flutter-2.8-candidate.16 branch; lgtm.

@itsjustkevin itsjustkevin merged commit 628f0e3 into flutter:flutter-2.8-candidate.16 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants