Skip to content

[flutter_tools] remove dummy implementation from abstract class .isEnabled()#96888

Merged
fluttergithubbot merged 4 commits into
flutter:masterfrom
chris-forks:test-tool-features
Jan 29, 2022
Merged

[flutter_tools] remove dummy implementation from abstract class .isEnabled()#96888
fluttergithubbot merged 4 commits into
flutter:masterfrom
chris-forks:test-tool-features

Conversation

@christopherfujino
Copy link
Copy Markdown
Contributor

@christopherfujino christopherfujino commented Jan 19, 2022 •
edited
Loading

Remove unused implementation of isEnabled in abstract class to ensure that it is not used by a future implementation that does not override.

christopherfujino
christopherfujino commented Jan 19, 2022
View reviewed changes
Comment thread packages/flutter_tools/lib/src/features.dart Outdated
Copy link
Copy Markdown
Contributor Author

@christopherfujino christopherfujino Jan 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this default was never called; I removed the implementation, so that future invocations will fail if a sub-class does not explicitly implement it.

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 20, 2022
@christopherfujino

This comment has been minimized.

Sign in to view
@christopherfujino christopherfujino marked this pull request as ready for review January 24, 2022 23:02
devoncarew
devoncarew reviewed Jan 28, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@devoncarew devoncarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@fluttergithubbot fluttergithubbot merged commit da88baf into flutter:master Jan 29, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2022
@engine-flutter-autoroll
da88baf [flutter_tools] remove dummy implementation from abstract cla…
4aef3e0 
…ss .isEnabled() (flutter/flutter#96888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2022
@engine-flutter-autoroll
da88baf [flutter_tools] remove dummy implementation from abstract cla…
4f75c17 
…ss .isEnabled() (flutter/flutter#96888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2022
@engine-flutter-autoroll
da88baf [flutter_tools] remove dummy implementation from abstract cla…
7419297 
…ss .isEnabled() (flutter/flutter#96888)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 29, 2022
Merged
godofredoc added a commit that referenced this pull request Feb 1, 2022
@godofredoc @christopherfujino
[flutter_releases] Flutter stable 2.10.0 Framework Cherrypicks (#97553)
5f105a6 
* [flutter_tools] remove dummy implementation from abstract class .isEnabled() (#96888)

* 'Update Engine revision to 776efd2 for stable release 2.10.0'

Co-authored-by: Christopher Fujino <christopherfujino@gmail.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
da88baf [flutter_tools] remove dummy implementation from abstract cla…
9dd85b7 
…ss .isEnabled() (flutter/flutter#96888)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@christopherfujino @clocksmith
[flutter_tools] remove dummy implementation from abstract class .isEn…
a5dcf03 
…abled() (flutter#96888)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csells csells Awaiting requested review from csells

1 more reviewer

@devoncarew devoncarew devoncarew approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christopherfujino @devoncarew @goderbauer @fluttergithubbot