Improve std::complex formatter#4050
Merged
Merged
Conversation
35c287a to
be1ba09
Compare
Contributor
Author
|
@vitaut |
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
vitaut
approved these changes
Jul 4, 2024
Contributor
vitaut
left a comment
There was a problem hiding this comment.
Thanks for the PR. All looks good but I'll merge it a bit later not to interfere with the upcoming patch release.
Contributor
Author
|
Current output |
Contributor
|
I missed the fix part. Makes sense to include in the patch release then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on ideas: #4034
Implemented:
sign,nanandinfhandling