Skip to content

feat: RFC metadata update API#10476

Merged
jennifer-richards merged 14 commits intoietf-tools:mainfrom
jennifer-richards:amend-published-rfc-api
Feb 27, 2026
Merged

feat: RFC metadata update API#10476
jennifer-richards merged 14 commits intoietf-tools:mainfrom
jennifer-richards:amend-published-rfc-api

Conversation

@jennifer-richards
Copy link
Member

Expands the purple_rfc_update() and purple_rfc_partial_update() APIs to allow updates beyond author lists. Adds some tests.

@jennifer-richards jennifer-richards marked this pull request as draft February 27, 2026 15:45
@jennifer-richards jennifer-richards marked this pull request as ready for review February 27, 2026 15:58
rudimatz
rudimatz previously approved these changes Feb 27, 2026
rjsparks
rjsparks previously approved these changes Feb 27, 2026
authors = RfcAuthorSerializer(many=True, min_length=1, source="rfcauthor_set")
def _update_authors(rfc, authors_data):
# Construct unsaved instances from validated author data
new_authors = [RfcAuthor(**ad) for ad in authors_data]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, my first reaction is "why are we talking about area directors here?"
I wonder if avoiding the sequence would help with future searches through the code too.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 81.39535% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.39%. Comparing base (8005a8b) to head (1c1127e).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
ietf/api/serializers_rpc.py 87.83% 9 Missing ⚠️
ietf/doc/utils.py 37.50% 5 Missing ⚠️
ietf/api/views_rpc.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10476      +/-   ##
==========================================
+ Coverage   88.36%   88.39%   +0.02%     
==========================================
  Files         325      326       +1     
  Lines       43653    43811     +158     
==========================================
+ Hits        38576    38725     +149     
- Misses       5077     5086       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jennifer-richards jennifer-richards merged commit c1c24d0 into ietf-tools:main Feb 27, 2026
10 checks passed
@jennifer-richards jennifer-richards deleted the amend-published-rfc-api branch February 27, 2026 18:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants