Skip to content

Event: Restrict test fallbacks to TestSwarm#4357

Closed
gibson042 wants to merge 1 commit into
jquery:masterfrom
gibson042:2019-04-event-TestSwarm-guards
Closed

Event: Restrict test fallbacks to TestSwarm#4357
gibson042 wants to merge 1 commit into
jquery:masterfrom
gibson042:2019-04-event-TestSwarm-guards

Conversation

@gibson042
Copy link
Copy Markdown
Member

Summary

Add guards as suggested by @mgol at #4354 (comment) .

Checklist

Copy link
Copy Markdown
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@timmywil
Copy link
Copy Markdown
Member

Just to be clear, did you want this merged into master, 3.4-stable, or both?

@mgol
Copy link
Copy Markdown
Member

mgol commented Apr 16, 2019

@timmywil This should definitely land on master but we may also cherry-pick that to 3.4-stable. It's not that important, though, IMO. We'll likely have more test improvements in the future and we won't backport all of the theoretically backwards compatible to 3.4-stable.

@mgol mgol added the Event label Apr 16, 2019
@mgol mgol closed this in bde53ed Apr 29, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants