Build: Fix AMD dependencies in curCSS#4380
Merged
Merged
Conversation
A leftover `rboxStyle` was left in the wrapper parameters but not in the dependency array, causing `getStyles` to be undefined in AMD mode. Since `rboxStyle` is no longer used, it's now removed. Ref jquerygh-4347
Member
Author
|
This is needed to unbreak AMD mode & there should be nothing controversial in this PR so I'd like to merge it shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A leftover
rboxStylewas left in the wrapper parameters but not in thedependency array, causing
getStylesto be undefined in AMD mode.Since
rboxStyleis no longer used, it's now removed.Ref gh-4347
Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com