Tests: replace express with basic Node server (3.x)#5531
Conversation
| "test/bundler_smoke_tests/**/*", | ||
| "test/promises_aplus_adapters/**", | ||
| "test/middleware-mockserver.js" | ||
| "test/middleware-mockserver.cjs" |
There was a problem hiding this comment.
I think we had said it'd be nice if this filename matched the main branch, so I've made that change in this PR.
| "@prantlf/jsonlint": "14.0.3", | ||
| "@types/selenium-webdriver": "4.1.24", | ||
| "body-parser": "1.20.2", | ||
| "archiver": "7.0.1", |
There was a problem hiding this comment.
This was missing from the release PR.
b0f2f3f to
250ad48
Compare
mgol
left a comment
There was a problem hiding this comment.
LGTM. Just a few questions about alignment, but not strictly related to this PR landing.
|
|
||
| /** | ||
| * Keep in sync with /test/middleware-mockserver.js | ||
| * Keep in sync with /test/middleware-mockserver.cjs |
There was a problem hiding this comment.
BTW, mock.php on main has some differences from the 3.x-stable version, mostly due to response formatting (3.x has more spaces). Spacey versions better suite our code style, but we should align regardless. middleware-mockserver.cjs has way fewer changes - mostly extra stuff for main which makes sense.
There was a problem hiding this comment.
I've copied what changes I thought made sense from main, but not the spacing. We can then switch the spacing on main.
b9e56d5 to
774d6bd
Compare
774d6bd to
9a76498
Compare
9a76498 to
0151455
Compare
Summary
3.x version of #5527 and #5532
Sample browserstack run: https://github.com/timmywil/jquery/actions/runs/10353380768
Checklist