open:fix memory leak when passing NULL to git_repository_open_ext#5224
Merged
ethomson merged 2 commits intolibgit2:masterfrom Sep 11, 2019
Merged
open:fix memory leak when passing NULL to git_repository_open_ext#5224ethomson merged 2 commits intolibgit2:masterfrom
ethomson merged 2 commits intolibgit2:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an example on the website for checking if a directory looks like a repository:
https://libgit2.org/docs/guides/101-samples/#repositories_openable
This example leaks memory. This pull request includes a test point which leaks memory and is caught by valgrind, plus a fix in git_repository_open_ext to dispose of buffers on the early return.