adds stats to ocsql#28
Merged
Merged
Conversation
Member
Author
|
PTAL @odeke-em |
odeke-em
approved these changes
Jan 16, 2019
Member
odeke-em
left a comment
There was a problem hiding this comment.
Thank you and nice work @basvanbeek, LGTM with one minor comment.
| startTime := time.Now() | ||
|
|
||
| return func(err error) { | ||
| timeSpent := float64(time.Since(startTime).Nanoseconds()) / 1e6 |
Member
There was a problem hiding this comment.
timeSpentMs
which will easily give anyone reading this code the context that these are in milliseconds.
| } | ||
| } | ||
|
|
||
| func recordCallStats(ctx context.Context, method string) func(err error) { |
odeke-em
reviewed
Jan 16, 2019
| }() | ||
|
|
||
| return func() { | ||
| close(done) |
Member
There was a problem hiding this comment.
Actually what we can do is ensure that this ever gets called once otherwise calling this again will cause a panic and some folks might misuse it.
var closeOnce sync.Once
return func() {
closeOnce.Do(func() {
close(done)
})
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial implementation of stats for ocsql.
closes #1