Add support for doc attribute on dataclass fields#12077
Merged
Conversation
Deploying pydantic-docs with
|
| Latest commit: |
0bf9bb0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa0b6ac4.pydantic-docs.pages.dev |
| Branch Preview URL: | https://dataclass-field-doc.pydantic-docs.pages.dev |
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
CodSpeed Performance ReportMerging #12077 will not alter performanceComparing Summary
|
Viicos
commented
Jul 21, 2025
| assert child.y == 1 | ||
|
|
||
|
|
||
| def test_kw_only_inheritance_on_field() -> None: |
Member
Author
There was a problem hiding this comment.
This would previously fail with an unhandled exception with 3.9. Although it doesn't make sense to use it in 3.9 (and we could add a warning -- not worth the effort as we'll drop support for it soon), still better to not hard error.
davidhewitt
approved these changes
Jul 23, 2025
Collaborator
davidhewitt
left a comment
There was a problem hiding this comment.
LGTM with tiny test suggestion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Introduced in python/cpython#114051.
Related issue number
Checklist