gh-66143: Allow copying of CodecInfo object#100432
gh-66143: Allow copying of CodecInfo object#100432furkanonder wants to merge 1 commit intopython:mainfrom furkanonder:issue-66143
Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM, but please add a NEWS entry.
|
@serhiy-storchaka I accidentally deleted my forked repository, so I can't update my old PRs. Is it possible for me to get update permission for my PRs? |
Can you add the news entry via the GitHub API? (Click on the link next to the failing check). Alternatively, if you put the wording of the news entry in a comment we can do that for you. |
|
@iritkatriel I couldn't send the news entry via https://blurb-it.herokuapp.com/add_blurb, it gives Alternatively, if you put the wording of the news entry in a comment we can do that for you.
|
|
Doesn't seem to work for me either. Would you like to create a new PR? |
I'll run the tool manually later this day and push a commit here. |
|
According to a list of branches in your CPython clone, it has no Anyway, here is generated |
it has no issue-66143 branch looked by this PR by name.
Could you push it here, please? Or recreate from the Files changed tab of this PR ans force-push.
|
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Nice. Since adding __getnewargs__ affects not only copy(). but also deepcopy() and pickling, please add tests for them. If they fail, it is good to, we only need to ensure that they do not produce wrong result.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Robert Lehmann