Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All commit authors signed the Contributor License Agreement.

An alternative fix would have been to add -32 to the tag name for PythonCore 32-bit versions which don't have it in the name. I can go back and implement it that way instead if this approach seems too complicated -- however, that would involve adding a few functions to properly update the tag without leaking.

I'd prefer this fix. Ideally this would be easy to remove when we decide that we actually don't care about end-of-life versions, since apparently it's too soon for that. Use the allocSearchInfoBuffer function to allocate a new buffer - these get attached to the SearchInfo structure and won't leak.

env.architecture isn't actually a good enough check if you care about EOL'd versions, you need to add GetBinaryType calls for when searching the HKCU registry key and assume 64-bit/32-bit based on the WOW6432Node selection for HKLM keys. It also should definitely be constrained to versions that definitely don't have -32 in the registry key, which IIRC is 3.4 and earlier? Possibly 3.5 as well, but I think I changed it in 3.5. Anything since then should follow the PEP 514 rules excluding back-compat allowances.

The parent fixes are good though, thanks! I thought I had tests that would ensure it was handling duplicated nodes properly, but I guess not.

env.architecture isn't actually a good enough check if you care about EOL'd versions, you need to add GetBinaryType calls for when searching the HKCU registry key and assume 64-bit/32-bit based on the WOW6432Node selection for HKLM keys

For the HKLM entries, I believe this is already covered by the fallbackArch argument, which sets env.architecture to the correct value based on which registry section was searched.

Good point on the HKCU entries though. I'll see where I can fit that in.

So, to recap my next changes:

• add detection of 32bit vs 64bit to HKCU entries,
• add "-32" to the tag name of the 32-bit entries which don't have it,
• constrain these two checks to PythonCore 2.X and 3.5 and lower,
• remove _compareArch, since architecture comparison will be implicit with the "-32" suffix always being present in the tag name,
• also remove the new code in _listAllEnvironments which appended "-32".

That sounds good.

Also verify that a command like py -2.7 will select 2.7-32 if that's the only option. It should, but my confidence in all my contributions over the last few months has been pretty well shattered, so check my work :)

Did a bunch of manual testing with 3.4 (fully pre-PEP 514) and 3.5 (includes executablePath and the "-32" in the tag for 32bit installations, but not full PEP 514), plus a few tests with 3.6 (follows PEP 514). I made sure to have the following behavior, as written in PEP 397:

• py -X.Y uses the 64-bit installation if there is one, 32-bit otherwise
• py -X.Y-64 uses the 64-bit installation, fails if there is none
• py -X.Y-32 uses the 32-bit installation, fails if there is none

In all cases, if the same version+architecture exists in both HKCU and HKLM, the HKCU entry is preferred.

Excellent! Thanks for the great work here.

Thanks @boimart1 for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

GH-101290 is a backport of this pull request to the 3.11 branch.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO 3.x has failed when building commit daec3a4.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/55/builds/2908) and take a look at the build logs.
4. Check if the failure is related to this commit (daec3a4) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/55/builds/2908

Failed tests:

• test_asyncio

Failed subtests:

• test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessPidfdWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

413 tests OK.

10 slowest tests:

• test_gdb: 2 min 19 sec
• test_concurrent_futures: 2 min 18 sec
• test_tools: 2 min 14 sec
• test_multiprocessing_spawn: 1 min 32 sec
• test_signal: 1 min 13 sec
• test_multiprocessing_forkserver: 1 min 10 sec
• test_asyncio: 1 min 8 sec
• test_multiprocessing_fork: 1 min 5 sec
• test_socket: 41.4 sec
• test_math: 35.8 sec

1 test failed:
test_asyncio

19 tests skipped:
test_check_c_globals test_devpoll test_ioctl test_kqueue
test_launcher test_msilib test_nis test_peg_generator
test_perf_profiler test_readline test_startfile test_tix
test_tkinter test_ttk test_winconsoleio test_winreg test_winsound
test_wmi test_zipfile64

1 re-run test:
test_asyncio

Total duration: 5 min 23 sec

Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_asyncio/test_subprocess.py", line 771, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.lto/build/Lib/test/test_asyncio/test_subprocess.py", line 763, in main
    self.assertEqual(events, [
AssertionError: Lists differ: [('pi[69 chars]), 'process_exited', 'pipe_connection_lost', '[17 chars]ost'] != [('pi[69 chars]), 'pipe_connection_lost', 'pipe_connection_lo[17 chars]ted']