Skip to content

gh-101703: use PyOS_snprintf instead of sprintf #101729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sobolevn wants to merge 17 commits into from
Closed

gh-101703: use PyOS_snprintf instead of sprintf #101729

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b33fb2d
gh-101703: use `snprintf` instead of `sprintf`
sobolevn Feb 9, 2023
8fb350d
Use `PyOS_snprintf`
sobolevn Feb 9, 2023
61eee4d
Convert more constant sized buffers
sobolevn Feb 9, 2023
ade334c
Convert ones using direct allocation
sobolevn Feb 9, 2023
9bc0864
Finish!
sobolevn Feb 9, 2023
ca2acae
Fix CI
sobolevn Feb 9, 2023
dff1e73
Bisect errors to a single place
sobolevn Feb 9, 2023
6953f30
Fix Windows x86
sobolevn Feb 9, 2023
6c60488
Convert `unicodeobject.c`
sobolevn Feb 9, 2023
cc74727
Fix `unicodeobject.c`
sobolevn Feb 9, 2023
95d6c52
Convert `string_parser.c`
sobolevn Feb 9, 2023
c7dd348
Convert `pystrtod.c`
sobolevn Feb 9, 2023
0e7bce1
Merge branch 'main' into issue-101703
sobolevn Feb 10, 2023
ae812b6
Address review comments
sobolevn Feb 10, 2023
8a95f08
Merge branch 'main' into issue-101703
sobolevn Apr 11, 2023
3e8e61f
Merge branch 'main' into issue-101703
sobolevn Apr 24, 2023
d82e315
Merge branch 'main' into issue-101703
sobolevn Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Windows x86
  • Loading branch information
@sobolevn
sobolevn committed Feb 9, 2023
commit 6953f3081cde76299f4b82220aff0b6acf87f885
2 changes: 1 addition & 1 deletion Modules/_ctypes/_ctypes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2639,7 +2639,7 @@ unique_key(CDataObject *target, Py_ssize_t index)
size_t bytes_left;

Py_BUILD_ASSERT(sizeof(string) - 1 > sizeof(Py_ssize_t) * 2);
cp += PyOS_snprintf(cp, sizeof(Py_ssize_t), "%x",
cp += PyOS_snprintf(cp, sizeof(string), "%x",
Py_SAFE_DOWNCAST(index, Py_ssize_t, int));
while (target->b_base) {
bytes_left = sizeof(string) - (cp - string) - 1;
Expand Down