Skip to content

gh-100061: Restore the global Input Stream pointer #102612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 9 commits into from
Aug 16, 2023
Merged

gh-100061: Restore the global Input Stream pointer #102612

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
007e7d7
pythongh-100061 Restore the global Input Stream pointer
uyw4687 Mar 11, 2023
43dc3cf
pythongh-100061 Refine comment
uyw4687 Mar 11, 2023
d33c012
gh-100061 Add github issue number on comments
uyw4687 Mar 13, 2023
8a958f1
gh-100061 Remove unneeded comment
uyw4687 Mar 13, 2023
b5476e4
gh-100061 Refine test case
uyw4687 Mar 13, 2023
2ffcc16
Add blurb entry
uyw4687 Mar 13, 2023
4c4b271
Merge branch 'main' into pythongh-100061
serhiy-storchaka Aug 16, 2023
86ca7e7
Re-enable possesive qualifiers in the commpiler.
serhiy-storchaka Aug 16, 2023
6656aa2
Refine tests.
serhiy-storchaka Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
gh-100061 Restore the global Input Stream pointer
  • Loading branch information
@uyw4687
uyw4687 committed Mar 11, 2023
commit 007e7d749bb0f3f289920666e5f894735316a8a8
2 changes: 2 additions & 0 deletions Lib/test/test_re.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2303,6 +2303,8 @@ def test_possessive_quantifiers(self):
self.assertIsNone(re.match("^x{}+$", "xxx"))
self.assertTrue(re.match("^x{}+$", "x{}"))

self.assertEqual(re.match('((.(?!C))++)', 'ABCD').span(), (0, 1))
Copy link
Copy Markdown

@ghost ghost Mar 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may add a comment # gh-100061 for this test-case.

Copy link
Copy Markdown
Contributor Author

@uyw4687 uyw4687 Mar 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, added :)


def test_fullmatch_possessive_quantifiers(self):
self.assertTrue(re.fullmatch(r'a++', 'a'))
self.assertTrue(re.fullmatch(r'a*+', 'a'))
Expand Down
3 changes: 3 additions & 0 deletions Modules/_sre/sre_lib.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,6 +1334,9 @@ SRE(match)(SRE_STATE* state, const SRE_CODE* pattern, int toplevel)
MARK_POP(ctx->lastmark);
LASTMARK_RESTORE();

/* Return to the previous Input Stream pointer */
state->ptr = ptr;

/* We have sufficient matches, so exit loop. */
break;
}
Expand Down