Skip to content

gh-103256: Fix hmac algorithm to support fallback implementation #103286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 3 commits into from
Apr 7, 2023
Merged

gh-103256: Fix hmac algorithm to support fallback implementation #103286

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6725ed9
gh-103256: Fix hmac algorithm to support fallback implementation
corona10 Apr 5, 2023
9147edc
Switch the test to using sha256 instead of md5 and avoid binascii.unh…
gpshead Apr 7, 2023
7cc2d6f
NEWS entry
gpshead Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Lib/test/test_hmac.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,16 @@ def test_with_digestmod_no_default(self):
with self.assertRaisesRegex(TypeError, r'required.*digestmod'):
hmac.HMAC(key, msg=data, digestmod='')

def test_with_fallback(self):
cache = getattr(hashlib, '__builtin_constructor_cache')
try:
cache['foo'] = hashlib.sha256
hexdigest = hmac.digest(b'key', b'message', 'foo').hex()
expected = '6e9ef29b75fffc5b7abae527d58fdadb2fe42e7219011976917343065f58ed4a'
self.assertEqual(hexdigest, expected)
finally:
cache.pop('foo')


class ConstructorTestCase(unittest.TestCase):

Expand Down
2 changes: 1 addition & 1 deletion Modules/_hashopenssl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ py_digest_by_name(PyObject *module, const char *name, enum Py_hash_type py_ht)
}
}
if (digest == NULL) {
_setException(PyExc_ValueError, "unsupported hash type %s", name);
_setException(state->unsupported_digestmod_error, "unsupported hash type %s", name);
return NULL;
}
return digest;
Expand Down