gh-105052:update timeit function's description#105060
gh-105052:update timeit function's description#105060terryjreedy merged 9 commits intopython:mainfrom
Conversation
…influence by timer parameter
|
All commit authors signed the Contributor License Agreement. |
terryjreedy
left a comment
There was a problem hiding this comment.
The PR could have waited for more discussion on the issue. See this comment for what I think the most important change for this issue should be, and where.
The Timer docstring has an obsolete and now wrong statement about the timer that should be deleted: ; the timer function is platform-dependent (see the module doc string)
Misc/NEWS.d/next/Documentation/2023-05-29-14-10-24.gh-issue-105052.MGFwbm.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks @Cherrymelon for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-108534 is a backport of this pull request to the 3.12 branch. |
--------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 7096a2b) Co-authored-by: R <cherrymelon@foxmail.com>
|
GH-108535 is a backport of this pull request to the 3.11 branch. |
--------- Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 7096a2b) Co-authored-by: R <cherrymelon@foxmail.com>
Update time unit description in
timeitfunction and add note to timeit doc pagetimeit.Timer.timeitshould mention that the return value depends on the timer #105052