Skip to content

gh-104050: Argument Clinic: Increase CConverter typing coverage #106932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erlend-aasland merged 3 commits into from
Jul 20, 2023
Merged

gh-104050: Argument Clinic: Increase CConverter typing coverage #106932

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7408259
gh-104050: Argument Clinic: Increase CConverter typing coverage
erlend-aasland Jul 20, 2023
5b94b7d
Naming: list => args
erlend-aasland Jul 20, 2023
7cce28f
Revert 'default' change
erlend-aasland Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Naming: list => args
  • Loading branch information
@erlend-aasland
erlend-aasland committed Jul 20, 2023
commit 5b94b7dd024b32c824b78982a84504d8360ac3ee
12 changes: 6 additions & 6 deletions Tools/clinic/clinic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2929,22 +2929,22 @@ def length_name(self) -> str:
# Why is this one broken out separately?
# For "positional-only" function parsing,
# which generates a bunch of PyArg_ParseTuple calls.
def parse_argument(self, list: list[str]) -> None:
def parse_argument(self, args: list[str]) -> None:
assert not (self.converter and self.encoding)
if self.format_unit == 'O&':
assert self.converter
list.append(self.converter)
args.append(self.converter)

if self.encoding:
list.append(c_repr(self.encoding))
args.append(c_repr(self.encoding))
elif self.subclass_of:
list.append(self.subclass_of)
args.append(self.subclass_of)

s = ("&" if self.parse_by_reference else "") + self.name
list.append(s)
args.append(s)

if self.length:
list.append("&" + self.length_name())
args.append("&" + self.length_name())

#
# All the functions after here are intended as extension points.
Expand Down