gh-107810: Improve DeprecationWarning for metaclasses with custom tp_new#107834
Merged
encukou merged 4 commits intopython:mainfrom Aug 10, 2023
Merged
gh-107810: Improve DeprecationWarning for metaclasses with custom tp_new#107834encukou merged 4 commits intopython:mainfrom
encukou merged 4 commits intopython:mainfrom
Conversation
Eclips4
reviewed
Aug 10, 2023
Misc/NEWS.d/next/C API/2023-08-10-11-12-25.gh-issue-107810.oJ40Qx.rst
Outdated
Show resolved
Hide resolved
Eclips4
approved these changes
Aug 10, 2023
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Member
|
Thank you for the PR! The wording looks weird to me though. Could you split it to two sentences, one about the concrete type and one about the behaviour being deprecated? |
Contributor
Author
|
@encukou Can this be backported to |
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
Buildbot failure unrelated. |
Contributor
|
GH-107864 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2023
…om tp_new (pythonGH-107834) (cherry picked from commit 16dcce2) Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @Eclips4 for the idea!
If accepted, it would be great if this change could be backported to
3.12. If not into3.12.0, than3.12.1.As example, for
protobufthe warning would change as such