Skip to content

gh-106581: Fix two bugs in the code generator's copy optimization #108380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 5 commits into from
Aug 24, 2023
Merged

gh-106581: Fix two bugs in the code generator's copy optimization #108380

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87eed12
Fix bug in copy detection
gvanrossum Aug 22, 2023
de494fc
Fix problem with copying from 'unused'
gvanrossum Aug 23, 2023
848822f
Do more clever things with copies
gvanrossum Aug 24, 2023
1ca845a
Fix mypy
gvanrossum Aug 24, 2023
652f9a1
Reduce complexity
gvanrossum Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix bug in copy detection 
I was comparing the last preceding poke with the *last* peek,
rather than the *first* peek.

Unfortunately this bug obscured another bug, which I have yet to fix:
When the last preceding poke is UNUSED, the first peek disappears,
leaving the variable unassigned.
  • Loading branch information
@gvanrossum
gvanrossum committed Aug 23, 2023
commit 87eed1237d2056de6f66ac95fa379533e94c3cf2
2 changes: 1 addition & 1 deletion Tools/cases_generator/stacking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ def __init__(
while (
pred.pokes
and self.peeks
and pred.pokes[-1].effect == self.peeks[-1].effect
and pred.pokes[-1].effect == self.peeks[0].effect
):
src = pred.pokes.pop(-1).effect
dst = self.peeks.pop(0).effect
Expand Down