Skip to content

Make all instructions macros internally.#108997

Closed
markshannon wants to merge 1 commit intopython:mainfrom
faster-cpython:all-instructions-are-macros
Closed

Make all instructions macros internally.#108997
markshannon wants to merge 1 commit intopython:mainfrom
faster-cpython:all-instructions-are-macros

Conversation

@markshannon
Copy link
Member

@markshannon markshannon commented Sep 6, 2023

Adds a de-sugaring pass that converts:

inst(LOAD_FAST, (-- value)) {
    value = GETLOCAL(oparg);
    assert(value != NULL);
    Py_INCREF(value);
}

into

op(_LOAD_FAST, (-- value)) {
    value = GETLOCAL(oparg);
    assert(value != NULL);
    Py_INCREF(value);
}
macro(LOAD_FAST) = _SAVE_CURRENT_IP + _LOAD_FAST

and converts occurrences of _SAVE_CURRENT_IP to SAVE_IP offset for the tier 2.

@markshannon
Copy link
Member Author

markshannon commented Sep 6, 2023

Fails with the error: AssertionError: Push or pop above current stack level: stack_pointer[0] when generating the code for LOAD_FAST_CHECK.

@gvanrossum
Copy link
Member

gvanrossum commented Sep 6, 2023

What problem are you trying to solve here? It would seem to be purely a problem of the structure of the code generator, because the "translation table" (_PyOpcode_opcode_metadata in pycore_opcode_metadata.h) already treats everything as a macro.

I don't quite follow what you're trying to do with _SAVE_CURRENT_IP.

@markshannon
Copy link
Member Author

markshannon commented Sep 11, 2023

I'm trying to make the semantics and behavior of each instruction completely explicit in the IR.

It keeps the back ends simpler, which is an overall improvement, as we have only one front-end, but many back ends.

We already have the following back-ends and we may get more:

  • Tier 1 interpreter generator
  • Ancillary table generator
  • Tier 2 interpreter generator
  • Abstract interpreter generator
  • Copy-and-patch stencil generator.

Each of these tools needs to understand the implicit conventions.
If nothing is implicit, they become much simpler.

@gvanrossum
Copy link
Member

gvanrossum commented Sep 11, 2023 •
edited
Loading

Let me take this and try to make it work, without including the SAVE_CURRENT_IP at the start of the generated macros.

@gvanrossum gvanrossum mentioned this pull request Sep 11, 2023
Closed
@gvanrossum gvanrossum closed this Sep 11, 2023
@markshannon markshannon deleted the all-instructions-are-macros branch September 26, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner will be requested when the pull request is marked ready for review Fidget-Spinner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markshannon @gvanrossum