Skip to content

gh-66143: Allow copying of CodecInfo object #109235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 24 commits into from
Sep 29, 2023
Merged

gh-66143: Allow copying of CodecInfo object #109235

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
e2b6a32
implement __getnewargs__ for codecs to use copy module
furkanonder Dec 22, 2022
e71ea50
test duplicated codec with the original codec
furkanonder Sep 10, 2023
c722e52
Merge branch 'main' into issue-66143
furkanonder Sep 10, 2023
089d89c
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 10, 2023
dbe168b
add test for deepcopy
furkanonder Sep 10, 2023
93070e8
Merge branch 'issue-66143' of github.com:furkanonder/cpython into iss…
furkanonder Sep 10, 2023
271de81
add pickle test for CodecInfo
furkanonder Sep 10, 2023
dff8e3c
add tests for a CodecInfo with _is_text_encoding equal to False
furkanonder Sep 10, 2023
6de32a6
Merge branch 'main' into issue-66143
furkanonder Sep 10, 2023
8c015be
remove white spaces
furkanonder Sep 10, 2023
bddde11
Merge branch 'issue-66143' of github.com:furkanonder/cpython into iss…
furkanonder Sep 10, 2023
f887190
add tests for a CodecInfo with _is_text_encoding equal to False
furkanonder Sep 10, 2023
cfc691c
remove white spaces
furkanonder Sep 10, 2023
73fec7d
update function name as test_deepcopy
furkanonder Sep 11, 2023
d8300cf
add equality test to test_copy
furkanonder Sep 11, 2023
bb6f4ba
add equality check to test methods
furkanonder Sep 11, 2023
f3d87eb
use base64 instead of rot13
furkanonder Sep 11, 2023
afea5b9
check name, incrementalencoder and _is_text_encoding in pickle test c…
furkanonder Sep 11, 2023
807dfd4
add assertIsNot check to pickle tests
furkanonder Sep 11, 2023
e3c6ce3
use base64 instead of rot13
furkanonder Sep 11, 2023
ef0df6a
add equality check to test methods
furkanonder Sep 11, 2023
026d1e2
add equality check to test methods
furkanonder Sep 11, 2023
9c12be6
Update 2023-09-10-20-23-20.gh-issue-66143.71xvgL.rst
serhiy-storchaka Sep 12, 2023
f0ea5c7
fix typo in news entry
furkanonder Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update function name as test_deepcopy 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
  • Loading branch information
@furkanonder @serhiy-storchaka
furkanonder and serhiy-storchaka authored Sep 11, 2023
commit 73fec7dbc71395d6498d324e68889f7e0caa6e6d
2 changes: 1 addition & 1 deletion Lib/test/test_codecs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1780,7 +1780,7 @@ def test_copy(self):
self.assertEqual(dup.name, orig.name)
self.assertEqual(dup.incrementalencoder, orig.incrementalencoder)

def test_deep_copy(self):
def test_deepcopy(self):
orig = codecs.lookup('utf-8')
dup = copy.deepcopy(orig)
self.assertIsNot(dup, orig)
Expand Down