gh-108747: Add unit tests for site.{usercustomize,sitecustomize} hooks#109470
Merged
hauntsaninja merged 12 commits intopython:mainfrom Oct 18, 2023
Merged
gh-108747: Add unit tests for site.{usercustomize,sitecustomize} hooks#109470hauntsaninja merged 12 commits intopython:mainfrom
hauntsaninja merged 12 commits intopython:mainfrom
Conversation
Contributor
Author
|
@hauntsaninja, I think you were the last person to edit site.py. Any chance I can have a review? Thanks! |
Contributor
Author
|
Friendly ping @hauntsaninja. Thanks. |
Contributor
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for adding a test! Not sure that I'm the right person to review, but left a comment :-)
Contributor
Author
|
Updated. @hauntsaninja if you have someone else in mind, feel free to add them. Thanks still. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing unit tests
site.{usercustomize,sitecustomize}hooks are never tested #108747