Skip to content

gh-109565: Fix concurrent.futures test_future_times_out() #109949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Sep 27, 2023
Merged

gh-109565: Fix concurrent.futures test_future_times_out() #109949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
gh-109565: Fix concurrent.futures test_future_times_out() 
as_completed() uses a timeout of 100 ms instead of 10 ms. Windows
monotonic clock resolution is around 15.6 ms.
  • Loading branch information
@vstinner
vstinner committed Sep 27, 2023
commit afcaa29325c19245c1c85f2b3e733db6c42e811c
7 changes: 5 additions & 2 deletions Lib/test/test_concurrent_futures/test_as_completed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,14 @@ def test_future_times_out(self):
EXCEPTION_FUTURE,
SUCCESSFUL_FUTURE}

for timeout in (0, 0.01):
# Windows clock resolution is around 15.6 ms
short_timeout = 0.100
for timeout in (0, short_timeout):
with self.subTest(timeout):

future = self.executor.submit(time.sleep, 0.1)
completed_futures = set()
future = self.executor.submit(time.sleep, short_timeout * 10)

try:
for f in futures.as_completed(
already_completed | {future},
Expand Down