Skip to content

gh-110662: multiprocessing test_async_timeout() increase timeout#110663

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:mp_test_async_timeout
Oct 11, 2023
Merged

gh-110662: multiprocessing test_async_timeout() increase timeout#110663
vstinner merged 1 commit intopython:mainfrom
vstinner:mp_test_async_timeout

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Oct 11, 2023 •
edited by bedevere-app bot
Loading

Increase timeout from 1 second to 30 seconds, if not longer. The important part is that apply_async() takes longer than TIMEOUT2.

@vstinner vstinner added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 11, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 11, 2023
Closed
@vstinner vstinner enabled auto-merge (squash) October 11, 2023 00:24
@vstinner
Copy link
Member Author

vstinner commented Oct 11, 2023

Windows x86 failed with:

FAIL: test_terminate (test.test_multiprocessing_spawn.test_threads.WithThreadsTestPool.test_terminate)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\Lib\test\_test_multiprocessing.py", line 2688, in test_terminate
    self.assertLess(join.elapsed, 2.0)
AssertionError: 27.2650000000001 not less than 2.0

Ubuntu failed with:

FAIL: test_terminate (test.test_multiprocessing_spawn.test_threads.WithThreadsTestPool.test_terminate)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/_test_multiprocessing.py", line 2688, in test_terminate
    self.assertLess(join.elapsed, 2.0)
AssertionError: 27.996608135999963 not less than 2.0

Surprise surprise, macOS failed with:

FAIL: test_terminate (test.test_multiprocessing_spawn.test_threads.WithThreadsTestPool.test_terminate)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/work/cpython/cpython/Lib/test/_test_multiprocessing.py", line 2688, in test_terminate
    self.assertLess(join.elapsed, 2.0)
AssertionError: 27.589956145999963 not less than 2.0

@vstinner
Copy link
Member Author

vstinner commented Oct 11, 2023

FAIL: test_terminate (test.test_multiprocessing_spawn.test_threads.WithThreadsTestPool.test_terminate)

I created issue gh-110666 for this kind of bug and I created PR gh-110667 to fix it.

@vstinner
Copy link
Member Author

vstinner commented Oct 11, 2023

At attempt #2, test_terminate of multiprocessing tests failed on even more tests, on macOS and Ubuntu. Oh. PR gh-110667 is really needed.

@vstinner
pythongh-110662: multiprocessing test_async_timeout() increase timeout
8de390e 
Increase timeout from 1 second to 30 seconds, if not longer. The
important part is that apply_async() takes longer than TIMEOUT2.
@vstinner vstinner force-pushed the mp_test_async_timeout branch from 60b25ab to 8de390e Compare October 11, 2023 02:12
@vstinner
Copy link
Member Author

vstinner commented Oct 11, 2023

I rebased the PR on the main branch to get commit 1556f42 fix.

@vstinner vstinner merged commit 790ecf6 into python:main Oct 11, 2023
@vstinner vstinner deleted the mp_test_async_timeout branch October 11, 2023 02:36
@miss-islington
Copy link
Contributor

miss-islington commented Oct 11, 2023

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2023
@vstinner @miss-islington
pythongh-110662: multiprocessing test_async_timeout() increase timeout (
5457da9 
pythonGH-110663)

Increase timeout from 1 second to 30 seconds, if not longer. The
important part is that apply_async() takes longer than TIMEOUT2.
(cherry picked from commit 790ecf6)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2023

GH-110674 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 11, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2023

GH-110675 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 11, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2023
@vstinner @miss-islington
pythongh-110662: multiprocessing test_async_timeout() increase timeout (
7752889 
pythonGH-110663)

Increase timeout from 1 second to 30 seconds, if not longer. The
important part is that apply_async() takes longer than TIMEOUT2.
(cherry picked from commit 790ecf6)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Oct 11, 2023
@miss-islington @vstinner
[3.12] gh-110662: multiprocessing test_async_timeout() increase timeo…
be381b5 
…ut (GH-110663) (#110674)

gh-110662: multiprocessing test_async_timeout() increase timeout (GH-110663)

Increase timeout from 1 second to 30 seconds, if not longer. The
important part is that apply_async() takes longer than TIMEOUT2.
(cherry picked from commit 790ecf6)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Oct 11, 2023
@miss-islington @vstinner
[3.11] gh-110662: multiprocessing test_async_timeout() increase timeo…
c6d5628 
…ut (GH-110663) (#110675)

gh-110662: multiprocessing test_async_timeout() increase timeout (GH-110663)

Increase timeout from 1 second to 30 seconds, if not longer. The
important part is that apply_async() takes longer than TIMEOUT2.
(cherry picked from commit 790ecf6)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit 790ecf6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/6061) and take a look at the build logs.
  4. Check if the failure is related to this commit (790ecf6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/6061

Failed tests:

  • test_signal

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_signal.py", line 1287, in test_stress_delivery_dependent
    self.assertEqual(len(sigs), N, "Some signals were lost")
AssertionError: 5755 != 10000 : Some signals were lost

@bedevere-bot
Copy link

bedevere-bot commented Oct 11, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL7 LTO + PGO 3.x has failed when building commit 790ecf6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/43/builds/4366) and take a look at the build logs.
  4. Check if the failure is related to this commit (790ecf6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/43/builds/4366

Failed tests:

  • test.test_multiprocessing_spawn.test_misc

Failed subtests:

  • test_resource_tracker_sigkill - test.test_multiprocessing_spawn.test_misc.TestResourceTracker.test_resource_tracker_sigkill

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/test/_test_multiprocessing.py", line 5598, in test_resource_tracker_sigkill
    self.check_resource_tracker_death(signal.SIGKILL, True)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-ppc64le.lto-pgo/build/Lib/test/_test_multiprocessing.py", line 5580, in check_resource_tracker_death
    self.assertEqual(len(all_warn), 1)
AssertionError: 0 != 1

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110662: multiprocessing test_async_timeout() increase timeout (
4d6f087 
python#110663)

Increase timeout from 1 second to 30 seconds, if not longer. The
important part is that apply_async() takes longer than TIMEOUT2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @miss-islington @bedevere-bot